Adjust fromChannel method to minimize injected headers and add examples#27
Merged
mkaufmann merged 2 commits intoforcedotcom:mainfrom Mar 12, 2025
Merged
Conversation
jdbc-core/src/main/java/com/salesforce/datacloud/jdbc/core/DataCloudConnection.java
Outdated
Show resolved
Hide resolved
…ples The intent of this change was to analyze how to use the JDBC driver in a least invasive way (compared to manual gRPC calling). To reach that minimum the `DataCloudConnection.fromChannel` method was adjusted to only add the must have interceptors, which - without usage of the corresponding connection parameters - are complete no ops. To demonstrate this flow a new `examples` test package was create that demonstrates the approach and serves as documentation. To write that test case (and minimize the use of helpers which would hide complexity) the test hyper instance variable with its getPort method was exposed as public. Drive-By:t - The hyper test instance was made non-static to avoid problems in parallel test execution. - A sample implementation of using the row based API to serve row based paginated results was also added and commented. With the parallel ongoing work we should see simplification of it.
mkaufmann
force-pushed
the
mkaufmann-add-examples
branch
from
d39b546 to
1555d4e
Compare
…ples The intent of this change was to analyze how to use the JDBC driver in a least invasive way (compared to manual gRPC calling). To reach that minimum the `DataCloudConnection.fromChannel` method was adjusted to only add the must have interceptors, which - without usage of the corresponding connection parameters - are complete no ops. To demonstrate this flow a new `examples` test package was create that demonstrates the approach and serves as documentation. To write that test case (and minimize the use of helpers which would hide complexity) the test hyper instance variable with its getPort method was exposed as public. Drive-By:t - The hyper test instance was made non-static to avoid problems in parallel test execution. - A sample implementation of using the row based API to serve row based paginated results was also added and commented. With the parallel ongoing work we should see simplification of it.
jschneidereit
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent of this change is to analyze how to use the JDBC driver in the least invasive way (compared to manual gRPC calling). To reach that minimum the
DataCloudConnection.fromChannelmethod was adjusted to only add the must have interceptors, which - without usage of the corresponding connection parameters - are complete no ops.To demonstrate this flow a new
examplestest package was create that demonstrates the approach and serves as documentation. To write that test case (and minimize the use of helpers which would hide complexity) the test hyper instance variable with its getPort method was exposed as public.Drive-By:t